Add missing 'Integration' suffix to tests #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were missing the Integration suffix in their names. This resulted in not including them in the 'make pkg-integration-test' command used when running tests on gh actions.
Michal-Leszczynski
force-pushed
the
ml/fix-test-suffix
branch
from
9676f36 to
72d1e1c
Compare
It is also useful for backup svc tests.
Michal-Leszczynski
force-pushed
the
ml/fix-test-suffix
branch
from
72d1e1c to
9743cbb
Compare
karol-kokoszka
approved these changes
Dec 20, 2024
Michal-Leszczynski
added a commit
that referenced
this pull request
Jan 15, 2025
* fix(backup_test): add missing 'Integration' suffix to tests Some tests were missing the Integration suffix in their names. This resulted in not including them in the 'make pkg-integration-test' command used when running tests on gh actions. * refactor(testutils): export CheckAnyConstraint It is also useful for backup svc tests. * fix(backup_test): skip TestBackupSkipSchemaIntegration for older Scylla versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were missing the
Integrationsuffix in their names.This resulted in not including them in the
make pkg-integration-testcommand used when running tests on gh actions.E.g.
TestBackupViewswas skipped in https://github.com/scylladb/scylla-manager/actions/runs/12372495884/job/34530829780.