Move the documentation to the website and complete it #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set up a Spark cluster with Ansible (and remove corresponding section from README) - Set up a Spark cluster with AWS EMR - Set up a Spark cluster manually - Set up a Spark cluster with Docker (and remove corresponding section from README) - Configure source for C* migration - Minor fixes in `config.yaml.example` - Minor typo fixes in Ansible files
|
Thanks @julienrf , once complete please ask @annastuchlik and @tarzanek for a review |
- Use proper syntax highlighting in code blocks - Fix some typos - Add a section describing how to configure the target database when migrating to Scylla - Add a page describing how to configure the source and target when migrating from DynamoDB
julienrf
force-pushed
the
write-some-docs
branch
from
bd94c74 to
25f536f
Compare
|
The PR is ready for review, could you please have a look @tarzanek and @annastuchlik? |
|
To make the review process easier, I’ve published the generated documentation here: https://julienrf.github.io/scylla-migrator/ |
Merged
guy9
requested changes
Jul 11, 2024
- Write “Apache Cassandra” instead of just “Cassandra” - Write “ScyllaDB” instead of “Scylla” - Fix internal links to make them compatible with a deployment of the site with a path prefix - Fix minor typos
julienrf
force-pushed
the
write-some-docs
branch
from
6164fd2 to
eb23794
Compare
|
@guy9 I addressed all your comments in eb23794. I’ve updated the website preview at https://julienrf.github.io/scylla-migrator. |
tarzanek
reviewed
Jul 12, 2024
tarzanek
reviewed
Jul 12, 2024
tarzanek
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #116
Fix #133
Fix #145
Fix #153