Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate indexes when replicating DynamoDB tables #173

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

julienrf
Copy link
Collaborator

Fixes #99

localSecondaryIndexes.asScala.map(localIndexRelevantProperties)
)

// Global secondary indexes: do not compare ARN and provisioned throughput (see https://github.com/scylladb/scylladb/issues/19718)
Copy link
Collaborator Author

@julienrf julienrf Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that scylladb/scylladb#19718 is not a real blocker, it only makes our tests a bit weaker than expected.

@julienrf julienrf marked this pull request as ready for review July 13, 2024 08:55
@julienrf julienrf marked this pull request as draft July 16, 2024 16:04
@julienrf julienrf force-pushed the replicate-indexes branch from b439884 to 2d4c2f6 Compare July 17, 2024 07:49
@julienrf julienrf marked this pull request as ready for review July 17, 2024 07:51
@guy9 guy9 requested a review from tarzanek July 21, 2024 07:03
@guy9
Copy link
Collaborator

guy9 commented Jul 21, 2024

Thanks, @tarzanek please review

@tarzanek
Copy link
Contributor

so the only question is if this should be always on, or there should be a optional switch to skip them

@tarzanek
Copy link
Contributor

@tarzanek
Copy link
Contributor

so LSI have to be populated immediatelly

but later on GSIs could be recreated once Scylla supports it, so at that time we will need optional switch to skip this (usually migration is slowed down by index creation and you want the index to be done in the end after all data is in, but it's just alternative, it's hard to say which option is better and it will depend on situation)

@tarzanek
Copy link
Contributor

let's implement the switch once Scylla supports GSI re-creation

@tarzanek tarzanek merged commit 6b83463 into scylladb:master Jul 24, 2024
1 check passed
@julienrf julienrf deleted the replicate-indexes branch July 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrator does not create Indexes based on DynamoDB table
3 participants