-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate indexes when replicating DynamoDB tables #173
Conversation
localSecondaryIndexes.asScala.map(localIndexRelevantProperties) | ||
) | ||
|
||
// Global secondary indexes: do not compare ARN and provisioned throughput (see https://github.com/scylladb/scylladb/issues/19718) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that scylladb/scylladb#19718 is not a real blocker, it only makes our tests a bit weaker than expected.
b439884
to
2d4c2f6
Compare
Thanks, @tarzanek please review |
so the only question is if this should be always on, or there should be a optional switch to skip them |
so LSI have to be populated immediatelly but later on GSIs could be recreated once Scylla supports it, so at that time we will need optional switch to skip this (usually migration is slowed down by index creation and you want the index to be done in the end after all data is in, but it's just alternative, it's hard to say which option is better and it will depend on situation) |
let's implement the switch once Scylla supports GSI re-creation |
Fixes #99