Switch to our fork of emr-dynamodb-connector #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #117 (comment) |
julienrf
force-pushed
the
use-dynamodb-connector-fork
branch
from
ab1f493 to
e8cd7f7
Compare
julienrf
force-pushed
the
use-dynamodb-connector-fork
branch
from
13c884b to
cd60263
Compare
|
The test failure is caused by a difference in the way we compute segments, see scylladb/emr-dynamodb-connector#8 |
|
This PR is ready for review (and merge!). In case we merge it, the next release version should be 1.0.0. If needed, we could keep a branch |
- Remove unnecessary logger configuration - Use the `DynamoDBInputFormat` class from the fork instead of maintaining our copy
julienrf
force-pushed
the
use-dynamodb-connector-fork
branch
from
bb26c4d to
3b2f53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167