Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panels for network compression #2325

Closed
amnonh opened this issue Jun 24, 2024 · 5 comments · Fixed by #2340
Closed

Add panels for network compression #2325

amnonh opened this issue Jun 24, 2024 · 5 comments · Fixed by #2340
Labels
enhancement New feature or request

Comments

@amnonh
Copy link
Collaborator

amnonh commented Jun 24, 2024

Scylla Enterprise has metrics for network compression, we should show that

@amnonh amnonh added the enhancement New feature or request label Jun 24, 2024
@amnonh amnonh added this to the Monitoring 4.8 milestone Jun 24, 2024
@amnonh
Copy link
Collaborator Author

amnonh commented Jun 24, 2024

@michoecho I'm not expecting you to add anything, I need an example of those metrics

@michoecho
Copy link
Contributor

michoecho commented Jun 24, 2024

@michoecho I'm not expecting you to add anything, I need an example of those metrics

You can use https://argus.scylladb.com/test/560830b0-a699-4028-8278-7d88d50a2693/runs?additionalRuns[]=5f1c8ee7-7df1-4969-b2aa-eecee660312f as an example workload run with compression metrics scraped.

Compression metric names start with scylla_rpc_compression_.

@michoecho michoecho removed their assignment Jun 24, 2024
amnonh added a commit to amnonh/scylla-grafana-monitoring that referenced this issue Jul 2, 2024
@tzach
Copy link
Contributor

tzach commented Jul 2, 2024

@zseta FYI

@mykaul
Copy link
Contributor

mykaul commented Jul 25, 2024

The panels should show compression ratio (per my discussion with @amnonh )

@mykaul mykaul reopened this Jul 25, 2024
@amnonh
Copy link
Collaborator Author

amnonh commented Jul 31, 2024

Fixed by #2369

@amnonh amnonh closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants