Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the installation instructions for 4.7.* #2303

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

benipeled
Copy link
Contributor

@amnonh once merged, it should be backported to the 4.7 branch (unless the docs are master base only)

@benipeled benipeled requested review from amnonh and annastuchlik May 27, 2024 10:14
@amnonh
Copy link
Collaborator

amnonh commented May 28, 2024

The weird thing, I already fixed it


.. code-block:: bash

wget -L https://github.com/scylladb/scylla-monitoring/archive/4.7.1.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change the wget command to use the -O tag, so it will work regardless of the version number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I got the point here - with -O we can specify a file-name-target but the URL-suffix does matter for this case, scylla-monitoring-x.y.z vs x.y.z,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a huge change, just make the second line simpler, I wander if we can use the same parameters for the latest version.


.. code-block:: bash

wget -L https://github.com/scylladb/scylla-monitoring/archive/4.7.1.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change the wget command to use the -O tag, so it will work regardless of the version number

@annastuchlik annastuchlik added the documentation Documentation related label Jun 4, 2024
@annastuchlik
Copy link
Contributor

Looks good. It must be backported, otherwise the instructions will show an incorrect version number.

@amnonh amnonh merged commit 62e810e into scylladb:master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants