-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the installation instructions for 4.7.* #2303
Conversation
The weird thing, I already fixed it |
|
||
.. code-block:: bash | ||
|
||
wget -L https://github.com/scylladb/scylla-monitoring/archive/4.7.1.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change the wget command to use the -O tag, so it will work regardless of the version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I got the point here - with -O
we can specify a file-name-target but the URL-suffix does matter for this case, scylla-monitoring-x.y.z
vs x.y.z
,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a huge change, just make the second line simpler, I wander if we can use the same parameters for the latest version.
|
||
.. code-block:: bash | ||
|
||
wget -L https://github.com/scylladb/scylla-monitoring/archive/4.7.1.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change the wget command to use the -O tag, so it will work regardless of the version number
Looks good. It must be backported, otherwise the instructions will show an incorrect version number. |
@amnonh once merged, it should be backported to the 4.7 branch (unless the docs are master base only)