grafana: Use intervalFactor 1 #94
Merged
+2,669
−2,421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I set scraping interval to 1s I see graphs "jiggle" in a way that historical data points change values. After looking closer at this it turns out that graphs alternate on refreshes between showing samples from only odd and only even timestamp values. This is because of intervalFactor being set to 1/2, even when auto-tuned step is small. Setting "resolution" parameter for queries from 1/2 to 1/1. The problem may still happen when the step is larger than scrape period, which can happen when viewing a long time range. There the solution would be to set the step to 1s. But I am not sure we want to do this by default, as it would make grafana unusuable when viewing long time ranges due to amount of data which would need to be fetched. Refs scylladb#45
tzach
reviewed
Nov 28, 2016
| @@ -377,7 +377,7 @@ | |||
| "targets": [ | |||
| { | |||
| "expr": "avg(seastar_reactor{type=\"gauge\", metric=\"load\"} ) by (instance)", | |||
| "intervalFactor": 2, | |||
| "intervalFactor": 1, | |||
| "refId": "A", | |||
| "step": 4 | |||
There was a problem hiding this comment.
@tgrabiec you left the step here as 4.
Is it intentional?
There was a problem hiding this comment.
Yes it's intentional. The step doesn't seem to be relevant in this change. I don't actually know what it signifies.
amnonh
added a commit
to amnonh/scylla-grafana-monitoring
that referenced
this pull request
Feb 17, 2021
…ce/' changes from 7a541804..bc069204 ae9a7ff5 Release 1.0.0 a3da86be Merge pull request scylladb#94 from el-psycho/master 0d98ebfa Fix duplicate alert rows b5e7ca5f Use correct logo file name aed6dac0 set type returned by custom functions 25d9489d cleanup query function 81db37c5 do not perform hidden queries 1e4bc9c4 update README b65e4b0c update README 0567785b allow filtering on receiver e4ffd46d update README f8a57a1f avoid error on empty records a73e51c2 rewrite datasource for grafana 7.x 4fe2aadf Merge pull request scylladb#66 from timmow/add-credentials 9e99e6cf Add withCredentials if present 7c574f4f update dependencies 511236da Merge pull request scylladb#64 from Mobiliteitsfabriek/feature/query-filters-silenced-active-inhibited 36e5a6ca Merge pull request scylladb#78 from camptocamp/dependabot/npm_and_yarn/websocket-extensions-0.1.4 b1714a5f Merge pull request scylladb#82 from camptocamp/dependabot/npm_and_yarn/lodash-4.17.19 f3eff01e Merge pull request scylladb#90 from camptocamp/dependabot/npm_and_yarn/ini-1.3.7 c20d3170 Bump ini from 1.3.5 to 1.3.7 1e63c2d2 Bump lodash from 4.17.15 to 4.17.19 59b35f8e Bump websocket-extensions from 0.1.3 to 0.1.4 0d4803bd Rebuild after rebasing e76612fc Support multiple filters ea5df703 Fix default for queryActive dc5b3e1d Fix formatting 2ee31740 Add support for querying inhibited or silenced too git-subtree-dir: grafana/plugins/camptocamp-prometheus-alertmanager-datasource git-subtree-split: bc069204ac8bc6e1b8bd713758470c02ee831b06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafana: Use resolution of 1/1
When I set scraping interval to 1s I see graphs "jiggle" in a way that
historical data points change values. After looking closer at this it
turns out that graphs alternate on refreshes between showing samples
from only odd and only even timestamp values. This is because of
intervalFactor being set to 1/2, even when auto-tuned step is small.
Setting "resolution" parameter for queries from 1/2 to 1/1.
The problem may still happen when the step is larger than scrape
period, which can happen when viewing a long time range. There the
solution would be to set the step to 1s. But I am not sure we want to
do this by default, as it would make grafana unusuable when viewing
long time ranges due to amount of data which would need to be fetched.
Refs #45