Bug fix: Dashboard Overview, Stat Joining #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem : does not show new pod joining How to simulate: 1. Deploy using scylla operator for 1 pod 2. Add 1 pod Root cause: Arithmetic addition in prometheus expr is not working if one condition is empty. Only work when both condition return value. Fix: Original code >count(scylla_node_operation_mode==1) + count(scylla_node_operation_mode==2)OR vector(0) Fixing code >count(scylla_node_operation_mode<=2)OR vector(0) Question: 1. Is this fix is acceptable? If yes, I will update the other related dashboard 2. Any script to run after updating the templates? I ran 'generate-dashboard.sh', it updated the files in grafana/build
c0ffeec0der
changed the title
|
Hi guys, any comment? I'd be happy to update the other templates :) |
|
@c0ffeec0der thanks for the PR. |
|
Issue created, #976 The generated dashboard:
Question:
|
|
You should run the ./generate-dashboard.sh per version:
|
Problem : does not show new pod joining How to simulate: 1. Deploy using scylla operator for 1 pod 2. Add 1 pod Root cause: Arithmetic addition in prometheus expr is not working if one condition is empty. Only work when both condition return value. Fix: Original code >count(scylla_node_operation_mode==1) + count(scylla_node_operation_mode==2)OR vector(0) Fixing code >count(scylla_node_operation_mode<=2)OR vector(0)
|
Ok, done. The other dashboard that have panel 'joining' is 'alternator'. Ran generate-dashboards.sh for all version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem :
does not show new pod joining
How to simulate:
Root cause:
Arithmetic addition in prometheus expr is not working if one condition is empty. Only work when both condition return value.
Fix:
Original code
Fixing code
Question: