New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty `CollectionType<T>` instead of `Option<CollectionType<T>>` #1001

Closed

Zk2u opened this issue May 15, 2024 · 3 comments · Fixed by #1057

Assignees

Labels

area/deserialization QoL

Milestone

Zk2u commented May 15, 2024

While ScyllaDB doesn’t distinguish between null and and empty set, it’s not very ergonomic to represent these collections as Option<CollectionType<T>>. For example, an empty set in Scylla should be deserialised into an empty HashSet<T>, not a None::<CollectionType<T>>.

This would be a breaking API change.

The text was updated successfully, but these errors were encountered:

Zk2u mentioned this issue

Empty set fails to deserialise back into empty hashset nodecosmos/charybdis#33

Closed

wprzytula self-assigned this

Collaborator

wprzytula commented May 15, 2024

I'll include this functionality in the ongoing deserialization refactor, planned for release 0.14.

wprzytula added this to the 0.14.0 milestone

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

e5b3f6b

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks.

wprzytula mentioned this issue

WIP: session_test: regression test for empty collections deserialization #1007

Closed

5 tasks

Collaborator

wprzytula commented May 21, 2024

@617a7aa Please take a look at #1007. Please confirm that the behaviour showcased by the added test is in line with your expectations.

Author

Zk2u commented May 21, 2024

ACK, looks good to me.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

1b457fd

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks.

wprzytula mentioned this issue

Introduce new deserialization API #1057

Merged

8 tasks

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

79c5bdf

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

6038ee0

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

12d12c4

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

671bf1e

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

89d1f6d

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

774e839

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

bf6b95b

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

e5982ba

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

136983e

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

088a9ab

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula modified the milestones: 0.14.0, 0.15.0

wprzytula added area/deserialization QoL labels

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

48417d0

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

ace6cf0

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          deser/value: convenient deserialization of empty collections

88632ef

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
Deserialization logic is modified to enable that.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

859a729

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

a0e7f2f

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

aef9803

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

1f2b998

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

66b3a10

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

73e18da

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

3dfc15c

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

562afba

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

c2a7fff

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

3c86f5a

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

bf9f218

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

5689d5d

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

ff62866

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

1eaa95a

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

f6e3716

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

505080c

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

ea0a434

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

5d0584b

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

64b5cd3

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

a261658

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

910a4d0

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

a8cc85b

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

8e6fa9a

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

04520d7

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

3185ca4

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

3aad7f6

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

36c63c5

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

76dd0d4

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

e53b7a8

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

74c7ea9

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula added a commit to wprzytula/scylla-rust-driver that referenced this issue


          session_test: regression test empty collections deserialization

e99b875

ScyllaDB does not distinguish empty collections from nulls. That is,
INSERTing an empty collection is equivalent to nullifying the
corresponding column.
As pointed out in
[scylladb#1001](scylladb#1001),
it's a nice QOL feature to be able to deserialize empty CQL collections
to empty Rust collections instead of `None::<RustCollection>`.
A test is added that checks it.

wprzytula closed this as completed in #1057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment