-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SerializeCql
to SerializeValue
#1000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
label
May 14, 2024
See the following report for details: cargo semver-checks output
|
Please also rename |
wprzytula
approved these changes
May 21, 2024
Replaced all occurrences of SerializeCql with SerializeValue.
muzarski
force-pushed
the
rename_serialize_cql
branch
from
May 22, 2024 12:06
5289f65
to
7440d3d
Compare
v1.1: rebased on top of main |
Lorak-mmk
approved these changes
May 31, 2024
@wprzytula / @Lorak-mmk I think this one can be merged, both of you approved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #905
Changes
SerializeCql
trait/macro toSerializeValue
. Changed all occurrences ofSerializeCql
toSerializeValue
(in the docs, etc.)serialize_cql
toserialize_value
in functions that implement derive macroimpl_serialize_cql_via_value
toimpl_serialize_value_via_value
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce../docs/source/
.Fixes:
annotations to PR description.