CI: fix issues related to [tokio::test]/[ntest::timeout] attributes and tablets with LWT
#1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
muzarski
force-pushed
the
toolchain_version
branch
from
9b97cde to
5e51b13
Compare
muzarski
force-pushed
the
toolchain_version
branch
2 times, most recently
from
85e9a78 to
19b48f1
Compare
muzarski
force-pushed
the
toolchain_version
branch
2 times, most recently
from
a908f83 to
8d4fc81
Compare
muzarski
force-pushed
the
toolchain_version
branch
from
8d4fc81 to
4060c7d
Compare
We decided to bump minimum required version of tokio to 1.34. Currently, the newest tokio version is 1.38, but some of the integration tests are eaten when testing with this specific verstion of tokio. Which is why, as of now, we decided not to support this version. The issue with version 1.38 is related to #[tokio::test] and #[ntest::timeout] attributes. Refs: - tokio-rs/tokio#6610 - becheran/ntest#28 - tokio-rs/tokio#6497
As of now, LWTs are not supported with tablets enabled. Marked the test for LWT + tablets with `#[ignore]`.
The separate job for tablets is not needed anymore, since tablets are stable in newest release of Scylla.
muzarski
force-pushed
the
toolchain_version
branch
from
4060c7d to
032fe2d
Compare
wprzytula
approved these changes
Jun 12, 2024
Lorak-mmk
approved these changes
Jun 13, 2024
muzarski
changed the title
[tokio::test]/[ntest::timeout] attributes and tablets with LWT
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with CI that happen lately.
Changes:
[tokio::test]and[ntest::timeout]attributes. Ref: regression: tokio::test in 1.38 eats my tests tokio-rs/tokio#6610. Remove this restriction once the issue is fixed.test_lwt_optimization_works_with_tabletswith#[ignore](tests LWT + tablets).tablets.ymlworkflow, since tablets are stable in newest releases of Scylla - no need to create a separate job for tablets which creates a cluster withccm.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.