errors: remove ParseError

[muzarski]

Ref: #519

This PR solves multiple issues:

No context for request serialization

I introduced a CqlRequestSerializationError, with the corresponding variants for each request type. Previously, the request serialization module would return ParseError, which did not provide much context.

Distinguishing between frame ser and deser errors

Decoupled FrameError (which originally was overloaded with variants corresponding to serialization and deserialization) into:

• CqlRequestSerializationError - in fact, I only moved the variant regarding frame body compression from FrameError to CqlRequestSerializationError
• FrameHeaderParseError - it corresponds to the errors that appear when Connection::reader() async task receives a frame, and tries to deserialize its header. It happens before the actual response handler is chosen (based on the stream id).
• FrameBodyExtensionsParseError - as the name suggests, it is returned when the driver fails to deserialize body extensions (e.g. frame warnings, or custom payload).

Test utilities making use of ParseError

There were a couple of test utilities used by scylla-proxy that would depend on ParseError. In some cases, if needed, I introduced new error types (e.g. RequestDeserializationError). I provided a docstring, noting that this is intended for driver's internal use and testing (it has to be pub, because of scylla-proxy crate).

Removing ParseError

With this PR, we could finally remove ParseError altogether! I believe that there are still some error-related issues to be addressed, but this is a huge step forward, as this was the most problematic error type.

Pre-review checklist

• I have split my patch into logically separate commits.
• All commit messages clearly explain what they change and why.
• [ ] I added relevant tests for new features and bug fixes.
• All commits compile, pass static checks and pass test.
• PR description sums up the changes and reasons why they should be introduced.
• I have provided docstrings for the public items that I want to introduce.
• [ ] I have adjusted the documentation in ./docs/source/.
• I added appropriate Fixes: annotations to PR description.

[github-actions]

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: 62c661b

See the following report for details:

cargo semver-checks output

./scripts/semver-checks.sh --baseline-rev ab07be6d8816df9ba53529391b65fbd63cc3e59a
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev ab07be6d8816df9ba53529391b65fbd63cc3e59a
     Cloning ab07be6d8816df9ba53529391b65fbd63cc3e59a
     Parsing scylla v0.14.0 (current)
      Parsed [  23.910s] (current)
     Parsing scylla v0.14.0 (baseline)
      Parsed [  20.701s] (baseline)
    Checking scylla v0.14.0 -> v0.14.0 (no change)
     Checked [   0.100s] 89 checks: 88 pass, 1 fail, 0 warn, 0 skip

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_missing.ron

Failed in:
  variant BrokenConnectionErrorKind::FrameError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla/src/transport/errors.rs:499
  variant RequestError::FrameError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla/src/transport/errors.rs:624
  variant ConnectionSetupRequestErrorKind::FrameError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla/src/transport/errors.rs:386
  variant CqlEventHandlingError::FrameError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla/src/transport/errors.rs:552

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  44.763s] scylla
     Parsing scylla-cql v0.3.0 (current)
      Parsed [  10.120s] (current)
     Parsing scylla-cql v0.3.0 (baseline)
      Parsed [  10.017s] (baseline)
    Checking scylla-cql v0.3.0 -> v0.3.0 (no change)
     Checked [   0.096s] 89 checks: 87 pass, 2 fail, 0 warn, 0 skip

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_missing.ron

Failed in:
  enum scylla_cql::frame::frame_errors::ParseError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla-cql/src/frame/frame_errors.rs:40
  enum scylla_cql::cql_to_rust::CqlTypeError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla-cql/src/frame/response/cql_to_rust.rs:20
  enum scylla_cql::frame::response::cql_to_rust::CqlTypeError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla-cql/src/frame/response/cql_to_rust.rs:20
  enum scylla_cql::frame::frame_errors::FrameError, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla-cql/src/frame/frame_errors.rs:12

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/inherent_method_missing.ron

Failed in:
  LegacySerializedValues::new_from_frame, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-ab07be6d8816df9ba53529391b65fbd63cc3e59a/789b83d096ad7d9a362060a8016a38862072c0e5/scylla-cql/src/frame/value.rs:803

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [  20.287s] scylla-cql
make: *** [Makefile:61: semver-rev] Error 1

[wprzytula]

ref: #1056

[muzarski]

Rebased on #1067

[wprzytula]

Mostly good direction, mainly nits.

[muzarski]

v1.2: addressed @Lorak-mmk 's comments:

• removed snap::Error and lz4_flex::block::DecompressError types from public API. Replaced them with dynamic Arc<dyn Error> in public enum variants.
• added docstring for FrameBodyExtensionsParseError

[muzarski]

@Lorak-mmk I also checked if we use any of these libraries' types in other parts of public API, but didn't find anything. You can double check that, if possible.

[muzarski]

@Lorak-mmk Rerun the CI, please. A known flaky test lwt_optimisation::if_lwt_optimisation_mark_offered_then_negotiatied_and_lwt_routed_optimally failed:

`Result::unwrap()` on an `Err` value: DbError(ServerError, "Failed to apply group 0 change due to concurrent modification")

[muzarski]

Can we merge?