Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: ignore result_large_err clippy lint for Tablet::from_raw_tablet #1095

Merged
merged 1 commit into from
Oct 21, 2024
Merged

clippy: ignore result_large_err clippy lint for Tablet::from_raw_tablet #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scylla/src/transport/locator/tablets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ pub(crate) struct Tablet {
}

impl Tablet {
// Ignore clippy lints here. Clippy suggests to
// Box<> `Err` variant, because it's too large. It does not
// make much sense to do so, looking at the caller of this function.
// Tablet returned in `Err` variant is used as if no error appeared.
// The only difference is that we use node ids to emit some debug logs.
#[allow(clippy::result_large_err)]
pub(crate) fn from_raw_tablet(
raw_tablet: RawTablet,
replica_translator: impl Fn(Uuid) -> Option<Arc<Node>>,
Expand Down
Loading