Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec_profile: expose public getters for profile configuration #1104

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

muzarski
Copy link
Contributor

Depends on: #1103

There is a use case for this in cpp-rust-driver.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • [ ] I have adjusted the documentation in ./docs/source/.
  • [ ] I added appropriate Fixes: annotations to PR description.

@muzarski muzarski requested review from wprzytula and Lorak-mmk and removed request for wprzytula October 24, 2024 15:11
Copy link

github-actions bot commented Oct 24, 2024

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: f9d554e

@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Oct 24, 2024
There is a use case for this in cpp-rust-driver
@muzarski muzarski force-pushed the exec-profile-getters branch from 6690d9a to f9d554e Compare October 24, 2024 15:32
@muzarski
Copy link
Contributor Author

Rebased on main

@github-actions github-actions bot removed the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Oct 24, 2024
@muzarski
Copy link
Contributor Author

Can someone merge?

@wprzytula wprzytula merged commit 07553fe into scylladb:main Oct 28, 2024
11 checks passed
@wprzytula wprzytula mentioned this pull request Nov 14, 2024
@muzarski muzarski deleted the exec-profile-getters branch December 19, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants