Shard aware port range #1303
Merged
Shard aware port range #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
muzarski
force-pushed
the
shard-aware-port-range
branch
2 times, most recently
from
abaf9ea to
21a0e2a
Compare
wprzytula
previously approved these changes
Apr 2, 2025
Lorak-mmk
previously approved these changes
Apr 2, 2025
Introduced ShardAwarePortRange (simple wrapper over RangeInclusive<u16> with validation) and exposed configuration options for shard-aware local port range.
These needed to be introduce as a separate methods, because current methods are `pub`. The public methods use new methods by providing the default port range. For now, I'm leaving new methods as `pub(crate)`. Reviewers can decide whether we want to expose them to users.
muzarski
force-pushed
the
shard-aware-port-range
branch
from
21a0e2a to
f04784b
Compare
Lorak-mmk
approved these changes
Apr 2, 2025
wprzytula
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1027
This PR introduces configuration option for shard-aware local port range.
Since not all ranges are valid (e.g. empty one, or one including reserved ports i.e. ports < 1024), I introduced a simple wrapper called
ShardAwarePortRangewhich validates provided range in constructor.Currently,
Sharderispub, so are its fields, and its methods responsible for computing local ports. This is why, I couldn't modify the sharder in any of the following ways:ShardAwarePortRangefield to theSharderShardAwarePortRangeparameter toShardermethodsThis is why, I introduced separate set of methods which additionally accept the port range. Current public methods are using new methods by providing a default range (ephemeral port range
[49152, 65535]).Pre-review checklist
[ ] I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.