Add serialize and deserialize support for DateTime<Utc> and secret #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piodul
approved these changes
Jan 5, 2023
|
It looks like we have some flakiness in tests runs with Cassandra... Failures don't seem to be related to the changes introduced here, so it's not a blocker for the PR. I re-ran the CI job and it is green now. Created an issue about the failures: #620 |
wprzytula
pushed a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Jan 17, 2023
…cylladb#619) Implement FromCqlVal and Value for DateTime and secrecy::Secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement FromCqlVal and Value for DateTime and secrecy::Secret.
Pre-review checklist
Fixes:annotations to PR description.