Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks/CI: make benchmarks compile and build them in CI #853

Merged
merged 2 commits into from
Oct 26, 2023
Merged

benchmarks/CI: make benchmarks compile and build them in CI #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2792714
benches: make them compile again
piodul Oct 20, 2023
9965289
CI: check/build all targets in rust workflow
piodul Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ jobs:
- name: Format check
run: cargo fmt --verbose --all -- --check
- name: Clippy check
run: cargo clippy --verbose --examples --tests -- -Aclippy::uninlined_format_args
run: cargo clippy --verbose --all-targets -- -Aclippy::uninlined_format_args
- name: Cargo check without features
run: cargo check --manifest-path "scylla/Cargo.toml" --features ""
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features ""
- name: Cargo check with secrecy feature
run: cargo check --manifest-path "scylla/Cargo.toml" --features "secret"
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "secret"
- name: Build scylla-cql
run: cargo build --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml"
- name: Build
run: cargo build --verbose --examples
run: cargo build --verbose --all-targets
- name: Run tests
run: SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose
- name: Stop the cluster
Expand All @@ -61,9 +61,9 @@ jobs:
- name: Print Rust version
run: rustc --version
- name: MSRV cargo check with features
run: cargo check --verbose --examples --tests
run: cargo check --verbose --all-targets
- name: MSRV cargo check without features
run: cargo check --verbose --manifest-path "scylla/Cargo.toml"
run: cargo check --verbose --all-targets --manifest-path "scylla/Cargo.toml"
- name: MSRV cargo check scylla-cql
run: cargo check --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml"

Expand Down
2 changes: 1 addition & 1 deletion scylla/benches/benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fn types_benchmark(c: &mut Criterion) {
c.bench_function("short", |b| {
b.iter(|| {
buf.clear();
types::write_short(-1, &mut buf);
types::write_short(u16::MAX, &mut buf);
types::read_short(&mut &buf[..]).unwrap();
})
});
Expand Down