Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about Cargo.lock.msrv to Contributing.md #913

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Jan 14, 2024

This is so that contributors (external or internal) are able to find information about how to deal with failures in min_rust CI job.

Fixes: #912

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested a review from piodul January 14, 2024 18:58
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
This is so that contributors (external or internal) are able to find
information about how to deal with failures in min_rust CI job.
This backtick is unnecessary, but breaks syntax highlighting
in VSCode.
@Lorak-mmk
Copy link
Collaborator Author

v2:

  • Addressed review comments
  • Unrelated small change: removed unnecessary backtick, as it was breaking syntax highlighting

@Lorak-mmk Lorak-mmk requested a review from piodul January 23, 2024 15:38
@piodul piodul merged commit 32197a5 into scylladb:main Jan 24, 2024
8 checks passed
@Lorak-mmk Lorak-mmk mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to update Cargo.lock.msrv
2 participants