Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: cargo clean before tests #929

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

muzarski
Copy link
Contributor

@muzarski muzarski commented Feb 9, 2024

Motivation

Recently, a new issue with CI have arisen. During the Run tests step in build job, the CI fails due to lack of space on the GH runner machine.

Here is the output of du -sh target/debug/* && df -h executed right before the tests on the runner machine:

133M	target/debug/build
2.2G	target/debug/deps
3.1G	target/debug/examples
4.6G	target/debug/incremental
8.0K	target/debug/libscylla.d
4.0K	target/debug/libscylla_cql.d
4.0K	target/debug/libscylla_macros.d
8.0K	target/debug/libscylla_proxy.d
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        73G   66G  7.0G  91% /
tmpfs           7.9G  172K  7.9G   1% /dev/shm
tmpfs           3.2G  1.4M  3.2G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        74G  4.1G   66G   6% /mnt
tmpfs           1.6G   12K  1.6G   1% /run/user/1001

We see that there is 7GB left on the disk. However, it's still not enough to compile the tests and examples in the debug mode:

 = note: /usr/bin/ld: final link failed: No space left on device
          collect2: error: ld returned 1 exit status
          

error: could not compile `scylla-proxy` (example "cmdline") due to previous error

Changes

  • execute cargo clean before running the tests in Run tests step.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

As of now, the CI doesn't pass simply because of no space
left on the device to proceed with the compilation of the tests.

In this commit we execute `cargo clean` before compilation and execution
of the tests.
@piodul piodul merged commit 56dd376 into scylladb:main Feb 12, 2024
11 checks passed
@Lorak-mmk Lorak-mmk mentioned this pull request May 9, 2024
@muzarski muzarski deleted the clean_before_tests branch October 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants