Deal with chrono deprecations #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
force-pushed
the
fix-chrono-duration-days
branch
from
3893ba6 to
0058d93
Compare
Chrono deprecated several method in 0.4.35 / 0.4.34 - chrono::Duration::days -> chrono::Duration::try_days New method was introduced in 0.4.33, so quite recently. This requires us to bump minimum chrono version. - NaiveDateTime::from_timestamp_opt -> DateTime::from_timestamp This requires some other changes, because of the switch from NaiveDateTime to DateTime. - NaiveDateTime::timestamp_millis -> .and_utc().timestamp_millis() I also added a comment explaining the implementation of CqlValueDisplayer and why it doesn't use existing `impl TryInto<NaiveDate> for CqlDate`.
Lorak-mmk
force-pushed
the
fix-chrono-duration-days
branch
from
0058d93 to
8648c3b
Compare
|
New APIs were added in 0.4.32, not 0.4.33 - updated the PR accordingly after verifying that it works after |
8 tasks
wprzytula
reviewed
Mar 7, 2024
Comment on lines
+69
to
+73
| // This is basically a copy of the code used in `impl TryInto<NaiveDate> for CqlDate` impl | ||
| // in scylla-cql. We can't call this impl because it is behind chrono feature in scylla-cql. | ||
|
|
||
| // date_days is u32 then converted to i64 then we subtract 2^31; | ||
| // Max value is 2^31, min value is -2^31. Both values can safely fit in chrono::Duration, this call won't panic |
There was a problem hiding this comment.
If we anyway use chrono in scylla unconditionally, why we even put it under feature in scylla_cql? What benefit could one have from disabling chrono in scylla_cql when it's still required in scylla ?
There was a problem hiding this comment.
Maybe less code generated for scylla-cql?
There was a problem hiding this comment.
This seems to be a very small gain compared to complexity added. Especially that, as you can see, we handle CqlDate with chrono anyway.
Tests doesn't serialize NaivedateTime, it serializes DateTime. It's not possible for it to serialize NaiveDateTime,as there is no such serialization implementation. Rename the test to reflect reality.
wprzytula
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrono deprecated several method in 0.4.35 / 0.4.34
chrono::Duration::days -> chrono::Duration::try_days New method was introduced in 0.4.33, so quite recently. This requires us to bump minimum chrono version.
NaiveDateTime::from_timestamp_opt -> DateTime::from_timestamp This requires some other changes, because of the switch from NaiveDateTime to DateTime.
NaiveDateTime::timestamp_millis -> .and_utc().timestamp_millis()
I also added a comment explaining the implementation of CqlValueDisplayer and why it doesn't use existing
impl TryInto<NaiveDate> for CqlDate.Fixes: #950
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.