Skip to content

Commit

Permalink
reactor: Mark drain() private
Browse files Browse the repository at this point in the history
It's only called by reactor itself on stop, no need in keeping it public

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
  • Loading branch information
xemul authored and avikivity committed Nov 3, 2024
1 parent 0818c05 commit 7ae238f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions include/seastar/core/reactor.hh
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,9 @@ private:

void configure(const reactor_options& opts);
int do_run();
// Waits for all background tasks on all shards
static future<> drain();

public:
explicit reactor(std::shared_ptr<smp> smp, alien::instance& alien, unsigned id, reactor_backend_selector rbs, reactor_config cfg);
reactor(const reactor&) = delete;
Expand Down Expand Up @@ -534,9 +537,6 @@ public:
run_in_background(futurize_invoke(std::forward<Func>(func)));
}

// Waits for all background tasks on all shards
static future<> drain();

/// Set a handler that will be called when there is no task to execute on cpu.
/// Handler should do a low priority work.
///
Expand Down

0 comments on commit 7ae238f

Please sign in to comment.