Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional data when segfaulting #2216

Open
nvartolomei opened this issue May 2, 2024 · 0 comments
Open

Additional data when segfaulting #2216

nvartolomei opened this issue May 2, 2024 · 0 comments

Comments

@nvartolomei
Copy link
Contributor

Currently a segfault is reported as:

Segmentation fault on shard 0.
Backtrace:
  ...

I believe we could add additional data about the context in which the segfault happens to aid debugging. I believe we should have access to the current scheduling group name, maybe tasktrace too. Anything else?

nvartolomei added a commit to nvartolomei/rp-seastar that referenced this issue May 4, 2024
Backtraces are printed in at least 2 cases:
  1) during segfaults,
  2) during reactor stalls.
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.

Ref scylladb#2216
nvartolomei added a commit to nvartolomei/rp-seastar that referenced this issue May 4, 2024
Backtraces are printed in at least 2 cases:
  1) during segfaults,
  2) during reactor stalls.
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.

Prior to this commit:

```
Segmentation fault on shard 0.
Backtrace:
  ...
```

With this commit:

```
Segmentation fault on shard 0, in scheduling group main.
Backtrace:
  ...
```

Ref scylladb#2216
nvartolomei added a commit to nvartolomei/rp-seastar that referenced this issue May 8, 2024
Backtraces are printed in at least 2 cases:
  1) during segfaults,
  2) during reactor stalls.
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.

Prior to this commit:

```
Segmentation fault on shard 0.
Backtrace:
  ...
```

With this commit:

```
Segmentation fault on shard 0, in scheduling group main.
Backtrace:
  ...
```

Ref scylladb#2216
nvartolomei added a commit to nvartolomei/rp-seastar that referenced this issue May 8, 2024
Backtraces are printed in at least 2 cases:
  1) during segfaults,
  2) during reactor stalls.
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.

Prior to this commit:

```
Segmentation fault on shard 0.
Backtrace:
  ...
```

With this commit:

```
Segmentation fault on shard 0, in scheduling group main.
Backtrace:
  ...
```

Ref scylladb#2216
xemul pushed a commit that referenced this issue May 14, 2024
Backtraces are printed in at least 2 cases:
  1) during segfaults,
  2) during reactor stalls.
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.

Prior to this commit:

```
Segmentation fault on shard 0.
Backtrace:
  ...
```

With this commit:

```
Segmentation fault on shard 0, in scheduling group main.
Backtrace:
  ...
```

Ref #2216

Closes #2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant