seastar-addr2line: support more flexible syslog-style backtraces #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please do not merge. |
Some may contain space characters around the '+' operator in, e.g.:
```
scylladb#1 0x00007fd2dab4f950 abort (libc.so.6 + 0x26950)
```
Fixes scylladb#1206
Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
bhalevy
force-pushed
the
seastar-addr2line-add-syslog-format
branch
from
8be90d1 to
35af86d
Compare
|
In v2 (35af86d):
|
So not to get confused by a prefix a spaces Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
|
@benipeled can you please update the seastar submodule in scylla_s3_reloc_server to include this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some may contain space characters around the '+' operator in, e.g.:
Fixes #1206
Signed-off-by: Benny Halevy bhalevy@scylladb.com