spawn_test: use BOOST_CHECK_EQUAL() #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemul
reviewed
Dec 2, 2022
| @@ -147,6 +149,11 @@ public: | |||
| bool empty() const noexcept { return !size(); } | |||
| /// Checks whether the buffer is not empty. | |||
| explicit operator bool() const noexcept { return size(); } | |||
|
|
|||
| friend std::ostream& operator<<(std::ostream& os, const temporary_buffer& b) { | |||
| return os << std::string_view{b.get(), b.size()}; | |||
There was a problem hiding this comment.
temporary buffer typically contains binary data, I don't feel comfortable adding a way to dump raw bytes into a terminal
There was a problem hiding this comment.
@xemul hi Pavel, yeah. i suspected this could be controversial despite that it was only used in test. but indeed, it does not make sense to dump binary to a terminal. dropped the commit adding operator<<().
…emporary_buffer so we can have better understanding of failures, if this test fails. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
temporary-buffer
branch
from
a437891 to
e2889e1
Compare
tchaikov
changed the title
|
changelog
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while debugging #1320, i ran into following failure on circleci:
see https://app.circleci.com/pipelines/github/tchaikov/seastar/280/workflows/dc64d0ce-fab2-47b1-a80e-9134e39695dc/jobs/3336