Make io-tester jobs share sched classes #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Early" is the place where we still can find some other job's class and share it if needed (later patches) Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
First -- register sched groups and io classes and collect them in a map. Second -- walk the list of jobs and grab the classes. This will allow jobs to shares classes with each other (next patch). Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
bhalevy
approved these changes
Feb 28, 2023
|
Looks good, but does io_tester.md not need to be updated? |
Right now different jobs live in different groups, so its impossible to, e.g. make a CPU hog job live in the same class with the IO-issuer. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
xemul
force-pushed
the
br-io-tester-shared-sched-groups
branch
from
cbf77cd to
6af831f
Compare
I didn't notice we had one 😕 Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jobs from io-tester's config all live in their own sched groups and io classes. This is not very flexible, add the ability to share sched classes as it was done for the RPC tester in 4d0ddc4 (rpc_tester: Allow sharing sched groups)
refs: #1083