demos/tcp_sctp_server_demo: Modernize with seastar::async and proper teardown #2685
+43
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teardown Replace deprecated at_exit() with the recommended seastar::async + defer() pattern. This change: - Captures background task future as member variable for proper cleanup - Implements complete service teardown sequence (abort accept → wait for task) - Upgrades to app.run() from deprecated app.run_deprecated() - Uses stop_signal for clean shutdown handling The demo now follows current Seastar best practices for initialization, resource management, and graceful termination. stop using at_exit(). Ref eefe659. which deprecated `at_exit()`. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated at_exit() with the recommended seastar::async + defer() pattern. This change:
The demo now follows current Seastar best practices for initialization, resource management, and graceful termination.
stop using at_exit().
Ref eefe659. which deprecated
at_exit().