Move LockDiff from dep into gps #213
Conversation
version.go
Outdated
| @@ -810,3 +810,23 @@ func hidePair(pvl []PairedVersion) []Version { | |||
| } | |||
| return vl | |||
| } | |||
|
|
|||
| // Decompose a Version into the underlying number, branch and revision | |||
There was a problem hiding this comment.
comment on exported function GetVersionInfo should be of the form "GetVersionInfo ..."
There was a problem hiding this comment.
Let's rename this to something a little more descriptive, if we're gonna export it - Info is pretty bland 😄
how about VersionComponentStrings()?
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 78.35% 78.62% +0.26%
==========================================
Files 28 29 +1
Lines 4020 4169 +149
==========================================
+ Hits 3150 3278 +128
- Misses 648 663 +15
- Partials 222 228 +6
Continue to review full report at Codecov.
|
| l1 = &SimpleLock{} | ||
| } | ||
| if l2 == nil { | ||
| l2 = &SimpleLock{} |
There was a problem hiding this comment.
Let's get some simple coverage for the zero value case
version.go
Outdated
| @@ -810,3 +810,23 @@ func hidePair(pvl []PairedVersion) []Version { | |||
| } | |||
| return vl | |||
| } | |||
|
|
|||
| // Decompose a Version into the underlying number, branch and revision | |||
There was a problem hiding this comment.
Let's rename this to something a little more descriptive, if we're gonna export it - Info is pretty bland 😄
how about VersionComponentStrings()?
|
I've renamed it per your suggestion and added tests for nil/empty locks. |
|
Great - in we go! Thanks! 🎉 |
|
In before reorg! 😁 |
|
🏁 🏁 🏁 |
Move LockDiff from dep into gps
LockDiffand related structs.gps.DiffLocks(l1, l2)andgps.DiffProjects(p1, p2).rawXpattern that locks use.