This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
Bimodal analysis #36
Merged
Bimodal analysis #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably a better design anyway, but it also helps with testing.
Finally got things together to the point where I'm integrating the analysis bits into the core of the algorithm. There are a couple classes of things to handle. First is moving from package names to repos - which, for now, we take to be the same as projects.
Second, we have the issues described originally - discrepancies between the manifest and the analysis.
|
Really need an automated process for redetecting and regenerating this.
bleh bleh turns out the static analysis needs work, and tests. doing that, then i think i can finally merge. |
Also add several more tests.
Just need to deal with prefix matching and trailing slashes.
...though, kinda not sure why that's correct.
...sorta. Gotta encapsulate this so that tests can swap out the impl.
WE HAVE FINALLY ARRIVED 🎉🎉🎉🎉🎉🎉🎉 |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Bimodal analysis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #35
Impl plan
fail()
analysis chooses what to marksolver.getImportsAndConstraintsOf()
HashInputs()
to incorporate root project static analysis