This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
Alternate approaches to populating a version queue #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idk why this was ever returning an atom
We can't ever (really) have a loop in our graph, so not much point in this.
Also refactor solver a bit for reuse purposes.
Too much complexity and too much performance hit for pretty marginal benefit, at least for MVP.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for some alternate means by which the version queue gets its versions. It encompasses #49 and #16, which are mostly urelated, except that they both required the same basic refactoring to `versionQueue itself in order to gracefully handle more than a single injected item (previously, the root lock version) at the front of the queue.