Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Add an image drop/crop control that does not use react #170

Open
wants to merge 3 commits into
base: release
Choose a base branch
from

Conversation

jemmyw
Copy link
Collaborator

@jemmyw jemmyw commented May 16, 2016

No description provided.

@TylorS
Copy link
Collaborator

TylorS commented May 16, 2016

👍

const evt$ = DOM.select('.crop').events('crop').share()

const image$ = evt$.flatMap(evt => {
const canvas = evt.originalTarget.cropper.getCroppedCanvas()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle.js uses evt.originTarget not originalTarget, but I did a console.log on this event and it doesn't seem to be patched by cycle-snabbdom, changing it to evt.target.cropper.getCroppedCanvas() worked for me locally though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants