Fusion rebase 45 #82
Merged
Fusion rebase 45 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
findepi
force-pushed
the
findepi/sdf/45
branch
2 times, most recently
from
61a8ee1 to
bba617e
Compare
Requiring k to be a literal should only apply to STRUCT.k With MAP[k] it is an excessive typechecking restriction, compared to what the operation is supposed to do.
Commit 0f4b8b1 introduced a new optimized evaluation mode for CASE expression with exactly one WHEN-THEN clause and ELSE clause being present. Apparently, the new mode did not take into account expensive or fallible expressions, as it unconditionally evaluated both branches. This is definitely incorrect for fallible expressions. For these, fallback to the original execution mode.
This DF version does not pass tests when cargo picks 54.3.0
Unclear why it doesn't work.
wizardxz
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.