-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: proposal for a way to configure dimmer colors #600
base: master
Are you sure you want to change the base?
Conversation
… light terminals, using a config variable named 'sdkman_colour_style' defaulting to 1 and that when set to 2 dimmer colors suitable to white/light colored terminals
I like the idea, but think it might be more beneficial if the colour be turned off completely. I like the use of the variable, but would probably call it something like sdkman_colour_enable. |
23b054e
to
7ee2c51
Compare
sdkman_colour_enable=true is already included in the config file, and it works correctly, this was to change the color to dim them, alternatively you could put a fixed "2" in place of the variable I introduced in the colored echo |
Evidently, it's been a while since I implemented that :-) Would it be possible to somehow make the config read something like:
That would be more intuitive for people trying to configure this. |
I've committed the change you suggested. |
… set to light/dark instead of the numeric values 1/2 (to be precise dark is detected for dimmed colors and anything else defaults to light)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, although as it stands it will default to the light configuration (since sdkman_colour_style
has never been set explicitly.
We require some further work to be done in the sdkman-hooks service to add this new configuration to the config file.
Don't worry about the Gitter bit, this is a new process that was introduced only after you raised your PR ;-)
proposal for a way to configure colors that are more readable on light terminals, using a config variable named 'sdkman_colour_style' defaulting to 1 and that when set to 2 uses dimmer colors suitable to white/light colored terminals. (I could not add the variable to the script executed upon installation since it is not under configuration here).