Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fix Typo in Stats Header #142

Merged
merged 1 commit into from
Jun 9, 2019
Merged

[Bug Fix] Fix Typo in Stats Header #142

merged 1 commit into from
Jun 9, 2019

Conversation

koolzz
Copy link
Member

@koolzz koolzz commented Jun 7, 2019 •
edited
Loading

The header says rx_drop and tx_drop but its actually rx and tx stat, this pr fixes that.

Summary:

Yeaaaaa, can't believe I didn't notice this one during release review.
First bug of 19.05, kudos to @Grace-Liu for helping find this one

Usage:
Just test the stats output modes.

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes 👍
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Can someone look through the args and confirm everything else is in the right spot

Review:

Pls review

@onvm
Copy link

onvm commented Jun 7, 2019

In response to PR creation

CI Message

Your results will arrive shortly

onvm
onvm suggested changes Jun 7, 2019
View reviewed changes
Copy link

@onvm onvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In response to PR creation

CI Message

Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
❌ Linter Failed (please fix style errors)

[Results from nimbnode30]

  • Median TX pps for Speed Tester: 38458094
  • Performance rating - 109.88% (compared to 35000000 average)

Linter Output

onvm/onvm_mgr/onvm_stats.h:62: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:63: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:65: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:66: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:67: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:69: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:70: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:72: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 8

@koolzz
Copy link
Member Author

koolzz commented Jun 7, 2019

@kevindweb can you review this one?

kevindweb
kevindweb approved these changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@kevindweb kevindweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely works! Tested with speed_testers, basic_monitor, pktgen, the usual. Good looks for finding that. Pretty surprised I didn't see this and I worked with stats for weeks!

@kevindweb
Copy link
Contributor

@onvm testing with another branch

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm testing with another branch

CI Message

Another CI run in progress, adding request to the end of the list

@kevindweb
Copy link
Contributor

@onvm test over here

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm test over here

CI Message

Another CI run in progress, adding request to the end of the list

@kevindweb
Copy link
Contributor

@onvm sorry for so many emails 2

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm sorry for so many emails 2

CI Message

Another CI run in progress, adding request to the end of the list

@kevindweb
Copy link
Contributor

@onvm sfes

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm sfes

CI Message

Another CI run in progress, adding request to the end of the list

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm sorry for so many emails 2

CI Message

Your results will arrive shortly

@kevindweb
Copy link
Contributor

@onvm queue me up

@kevindweb
Copy link
Contributor

@onvm ignore me

@kevindweb
Copy link
Contributor

@onvm are we going to work

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm are we going to work

CI Message

Duplicate request already waiting, ignoring message

@kevindweb
Copy link
Contributor

@onvm test

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm test

CI Message

Another CI run in progress, adding request to the end of the list

@onvm
Copy link

onvm commented Jun 8, 2019

@onvm are we going to work

CI Message

Your results will arrive shortly

@koolzz
Copy link
Member Author

koolzz commented Jun 9, 2019

@onvm whats the deal with CI rn

@onvm
Copy link

onvm commented Jun 9, 2019

@onvm whats the deal with CI rn

CI Message

Your results will arrive shortly

onvm
onvm suggested changes Jun 9, 2019
View reviewed changes
Copy link

@onvm onvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onvm whats the deal with CI rn

CI Message

Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
❌ Linter Failed (please fix style errors)

[Results from nimbnode30]

  • Median TX pps for Speed Tester: 38479820
  • Performance rating - 109.94% (compared to 35000000 average)

Linter Output

onvm/onvm_mgr/onvm_stats.h:62: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:63: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:65: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:66: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:67: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:69: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:70: Lines should be <= 120 characters long [whitespace/line_length] [5]
onvm/onvm_mgr/onvm_stats.h:72: Lines should be <= 120 characters long [whitespace/line_length] [5]
Total errors found: 8

@koolzz koolzz merged commit 1eac409 into sdnfv:develop Jun 9, 2019
koolzz added a commit that referenced this pull request Jun 9, 2019
@koolzz
Merge pull request #144 from sdnfv/develop
ea0bf0c 
This PR adds the following bug fix to the master branch:
[Bug Fix] Fix Typo in Console Stats Header (#142)
@koolzz koolzz added this to the ONVM v19.07 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onvm onvm onvm requested changes

@kevindweb kevindweb kevindweb approved these changes

Assignees
No one assigned
Labels
bug fix 🐛
Projects
None yet
Milestone
ONVM v19.07
Development

Successfully merging this pull request may close these issues.
3 participants
@koolzz @onvm @kevindweb