Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix Stats Header in Release Notes #145

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

koolzz
Copy link
Member

@koolzz koolzz commented Jun 11, 2019

Fix the stats header type

Short description as this is just a Readme change. Is there anything else we need to change I'm planning to merge this into master so this should be merged before CI stuff. Please take a look and tell me if there are any other notes/fixes I should add to this.
@dennisafa @kevindweb

@onvm
Copy link

onvm commented Jun 11, 2019

In response to PR creation

CI Message

Your results will arrive shortly

Copy link
Contributor

@kevindweb kevindweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i like this now, I put it through a spell/grammar checker the other day and gave you all the suggestions which you seem to have changed 👍

@koolzz
Copy link
Member Author

koolzz commented Jun 12, 2019

@onvm results?

@onvm
Copy link

onvm commented Jun 12, 2019

@onvm results?

CI Message

Your results will arrive shortly

Copy link

@onvm onvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onvm results?

CI Message

Run successful see results:
✔️ PR submitted to develop branch
✔️ Speed tester performance check passed
✔️ Linter passed

[Results from nimbnode30]

  • Median TX pps for Speed Tester: 38479674
  • Performance rating - 109.94% (compared to 35000000 average)

@koolzz koolzz merged commit dcc4795 into sdnfv:develop Jun 12, 2019
koolzz added a commit that referenced this pull request Jun 12, 2019
[Bug Fix] Fix Stats Header in Release Notes (#145)
@koolzz koolzz added this to the ONVM v19.07 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants