-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn user when not specifying -m flag in start_nf.sh #158
Conversation
CI MessageYour results will arrive shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In response to PR creation
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Pktgen performance check passed
✔️ Speed Test performance check passed
✔️ Linter passed
[Results from nimbnode17]
-
Median TX pps for Pktgen: 10488087
Performance rating - 104.88% (compared to 10000000 average) -
Median TX pps for Speed Tester: 40206145
Performance rating - 100.52% (compared to 40000000 average)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, really just a bash nit, and Nick can dispute, but personally I like combining those conditions, as well as using built-in regex.
[[ $DPDK_ARGS =~ "-l" && ! $ONVM_ARGS =~ "-m" ]]
Lgtm, testing is on you though. I like @kevindweb nit looks elegant |
looks clean! |
@onvm I will test, but please work correctly |
CI MessageYour results will arrive shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onvm I will test, but please work correctly
CI Message
Run successful see results:
✔️ PR submitted to develop branch
✔️ Pktgen performance check passed
✔️ Speed Test performance check passed
✔️ Linter passed
[Results from nimbnode17]
-
Median TX pps for Pktgen: 10324681
Performance rating - 103.25% (compared to 10000000 average) -
Median TX pps for Speed Tester: 40200841
Performance rating - 100.50% (compared to 40000000 average)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with CI and cloudlab, all performance looks good, as well as Pktgen, and multiple speed testers running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen the warning so approving
Warn the user if -m isn't specified in start_nf.sh
Summary:
You can bind a core manually using -l and -m in the start_nf script. If -m isn't specified, no binding will occur. This change will let the user know that they should supply this flag if they want the binding to occur.
Usage:
Run any NF using the
./start_nf.sh NF-NAME DPDK_ARGS -- ONVM_ARGS -- NF_ARGS
format(i.e,
./start_nf.sh speed_tester -l 5 -- -m -r 3 -- -d 2
where is -l is the core # to assign, and -m is the binding flag)Merging notes:
TODO before merging :
Test Plan:
Run the start_nf script without and with the -m flag.
Review:
@koolzz @kevindweb