Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated moongen installation memo link, updated pktgen installation m… #189

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Updated moongen installation memo link, updated pktgen installation m… #189

merged 1 commit into from
Mar 2, 2020

Conversation

catherinemeadows
Copy link
Contributor

Fixed broken links in documentation files (fixes issue #187)

Summary:

Fixed MoonGen installation guide ink in openNetVM/docs/NF_Dev.md. Fixed Pktgen installation guide link in openNetVM/tools/Pktgen/README.md. Fixed "step 3" anchors in openNetVM/docs/Install.md so now we can click on the "step 3" link and be redirected to the correct section in the install guide.

Usage:

This PR includes
Resolves issues X
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Previewed documentation files that were altered and tested new links to make sure they were redirecting correctly.

Review:

Updated moongen installation memo link, updated pktgen installation m…
0feca69 
…emo link, and updated anchor links in installation openNet installation guide
@onvm
Copy link

onvm commented Feb 20, 2020

In response to PR creation

CI Message

Your results will arrive shortly

onvm
onvm approved these changes Feb 20, 2020
View reviewed changes
Copy link

@onvm onvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In response to PR creation

CI Message

Run successful see results:
✔️ PR submitted to develop branch
✔️ Linter passed

dennisafa
dennisafa approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@dennisafa dennisafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates are always needed 👍🏼

twood02
twood02 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@twood02 twood02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@twood02 twood02 added the ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge label Feb 27, 2020
@koolzz koolzz merged commit 6b2da73 into sdnfv:develop Mar 2, 2020
@twood02 twood02 added this to the ONVM 20.05 milestone Apr 9, 2020
@dennisafa dennisafa mentioned this pull request May 3, 2020
Closed
3 tasks
@twood02 twood02 added NeedsReleaseNote Needs updated release note info and removed NeedsReleaseNote Needs updated release note info labels May 22, 2020
@catherinemeadows catherinemeadows deleted the linkUpdates branch April 27, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisafa dennisafa dennisafa approved these changes

@onvm onvm onvm approved these changes

@twood02 twood02 twood02 approved these changes

Assignees

@dennisafa dennisafa

Labels
ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge
Projects
None yet
Milestone
ONVM 20.05
Development

Successfully merging this pull request may close these issues.
5 participants
@catherinemeadows @onvm @twood02 @dennisafa @koolzz