MAC address fix

[catherinemeadows]

Fixes the load_generator bug mentioned in #222

Summary:

In order to resolve the issue where the "Failed to obtain MAC address" error is raised in the load_generator NF, the function onvm_get_fake_macaddr() is used to obtain a fake MAC address for testing or in the case that the provided MAC address of the port is not bound to DPDK.

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes	👍
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

• Dependencies: None

TODO before merging :

• PR is ready for review

Test Plan:

Ran the load_generator NF with the MAC address of the node I am testing with. I had @sreya519 run this fix for the load_generator as well since she experienced this error.

Review:

@sreya519 --> tested the load_generator fixes already

[onvm]

In response to PR creation

CI Message

Your results will arrive shortly

[onvm]

In response to PR creation

CI Message

Error: ERROR: Failed to post results to GitHub

[EthanBaron14]

@onvm try again?

[onvm]

@onvm try again?

CI Message

Your results will arrive shortly

[onvm]

@onvm try again?

CI Message

Error: ERROR: Failed to post results to GitHub

[EthanBaron14]

This worked for me. Made sure to checkout on the PR branch, ran the manager with the default syntax and ran the load generator NF with ./go.sh 1 -d 2 -m <Nimbus node MAC address> and had no issues. Did not see the "Failed to obtain MAC address" error.

[catherinemeadows]

@onvm is this working now?

[onvm]

@onvm is this working now?

CI Message

Your results will arrive shortly

[onvm]

@onvm is this working now?

CI Message

Run successful see results:
Test took: 5 minutes, 23 seconds
✔️ Pktgen performance check passed
✔️ Speed Test performance check passed

[Results from nimbnode23]

• Median TX pps for Pktgen: 7721721
  Performance rating - 100.28% (compared to 7700000 average)

• Median TX pps for Speed Tester: 42227047
  Performance rating - 100.54% (compared to 42000000 average)

[koolzz]

Good fix, remove it from lb and I'll approve

[koolzz]

lgtm

[dennisafa]

Looks good - lets add a RTE_LOG(INFO, APP, "") (dpdk's print statement) somewhere to let the user know we're using a fake mac addr (as discussed on slack)

[catherinemeadows]

speed_tester has the same setup. Should we add the same print to it as well? @dennisafa

[EthanBaron14]

Looks good to me. Tested again using same configuration as above. No problems.

[kevindweb]

@catherinemeadows I think it would be useful to have a print statement like this one in speed_tester

[dennisafa]

Agreed - sorry I missed this comment. A comment wherever we fake it is a good idea.