Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pktgen documentation updates #239

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Conversation

sreyanalla
Copy link
Contributor

@sreyanalla sreyanalla commented Jun 23, 2020

Summary:

Improves the existing Pktgen installation guide by providing clarity on Lua installation. Pertains to #181 , which requests Pktgen documentation updates.

Please see Pktgen Wiki page, which fully resolves the issue mentioned above.

This PR includes
Resolves issues #181
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Guide now includes clear instructions on Lua installation and adds reference to the Wiki page for further guidance
revised info, syntax, grammar, minor fixes
@onvm
Copy link

onvm commented Jun 23, 2020

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

Copy link
Member

@dennisafa dennisafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the updates

@dennisafa dennisafa merged commit bb11cda into sdnfv:develop Jul 22, 2020
@sreyanalla sreyanalla deleted the pktgendocs branch August 4, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants