Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with description of config file. #258

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

WilliamMaa
Copy link
Contributor

This PR is made to resolve the linter problem in PR #241
The original PR is made by @khaledshahine

Summary:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

@onvm
Copy link

onvm commented Sep 17, 2020

In response to PR creation

CI Message

Aborting, need an authorized user to run CI

Copy link
Member

@dennisafa dennisafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the linter complain about readme's? Seems pedantic.

@WilliamMaa
Copy link
Contributor Author

@dennisafa The original PR #241 had the linter problem, I think it was because @khaledshahine tried to PR it into a wrong branch? I just copied what he did in that PR and see if this could resolve that issue.

Copy link
Contributor

@kevindweb kevindweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me👍

@dennisafa dennisafa merged commit 313322e into sdnfv:develop Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants