Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aesdecrypt.c #304

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Update aesdecrypt.c #304

merged 1 commit into from
Aug 24, 2021

Conversation

PengWu-wp
Copy link
Contributor

The PR fixes the NF_TAG of aesdecrypt in openNetVM/examples/aes_decrypt/aesdecrypt.c.

Summary:

NF_TAG of aesdecrypt is incorrectly set to "aes_encrypt" in openNetVM/examples/aes_decrypt/aesdecrypt.c

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes x
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Run openNetVM manager and aesdecrypt NF, NF_TAG "aes_decrypt" should be displayed.

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

Copy link
Member

@twood02 twood02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this!

Copy link
Contributor

@NoahChinitz NoahChinitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@twood02 twood02 added this to the ONVM 21 Summer Release milestone Aug 23, 2021
@twood02 twood02 added the ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge label Aug 23, 2021
@dennisafa dennisafa merged commit a35035d into sdnfv:develop Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix 🐛 ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants