-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ae04a9 ae681f ae5f50 #273
Merged
Merged
ae04a9 ae681f ae5f50 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also changed twitter image URLs to an actual filename
@dziban303 I would put the image on AE5F50 |
@Phaeton done |
Question, should AE5F50 have the reg as 169567 vs tactical? |
@Phaeton done. also added pics for 🐺🐶 ae68b3. I'm done with this PR |
Phaeton
requested changes
Jul 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo on AE04A9's Type
Weird. Not sure how I managed to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added ae04a9 and ae681f, with images, and AE5F50, without. AE681F is a P-8 tactical hex but was most recently used by 169567—this aircraft also uses AE5F50, as it did ten hours ago. Which hex the photos should go into is sort of a dilemma, but I opted to put them into the hex it was most recently using.
Would like @Phaeton 's take on the image question. Should I add the same images to both hexes maybe? Or neither? Or the other one? Ugh
AE04A9 is an Army Citation.
Final content
Checklist before requesting a review