Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen #7

Merged
merged 2 commits into from
Dec 3, 2017
Merged

Regen #7

merged 2 commits into from
Dec 3, 2017

Conversation

GuillaumeGomez
Copy link
Contributor

Very sorry but I can't build it on my linux because my packages are too old. I can check it this evening though.

@sdroege
Copy link
Owner

sdroege commented Nov 27, 2017

It's failing because the code got some new "extern crate" but the Cargo.toml was not updated. However those crates are actually not used, so shouldn't be there to begin with.

Also this update is "breaking" the versions in build.rs and Cargo.toml. It is removing some version features, which are there for consistency (everything has features for the major versions, 1.0, 1.2, 1.4, etc, independent of whether API was added or not... to make it simpler for users to select their required version without having to think/check).

@GuillaumeGomez
Copy link
Contributor Author

I'll clean this PR this evening then. :)

@GuillaumeGomez GuillaumeGomez force-pushed the regen branch 4 times, most recently from 52e8ebd to e7dcf22 Compare December 2, 2017 12:46
@GuillaumeGomez
Copy link
Contributor Author

Updated, sorry for the delay. There is still an issue remaining for the debug generation in gir (for cases like [c_int; 64], no Debug...).

@GuillaumeGomez
Copy link
Contributor Author

This issue should be fixed by rust-lang/rust#46445.

extern crate glib_sys as glib;
extern crate gobject_sys as gobject;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause warnings about unused crates

libc = "0.2"
glib-sys = { git = "https://github.com/gtk-rs/sys" }
gobject-sys = { git = "https://github.com/gtk-rs/sys" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused crates

@GuillaumeGomez
Copy link
Contributor Author

@sdroege: Fixed and updated.

@sdroege
Copy link
Owner

sdroege commented Dec 3, 2017

@@ -13,6 +13,9 @@ path = "../gstreamer-sys"
[dependencies.gstreamer-base-sys]
path = "../gstreamer-base-sys"

[dependencies.gstreamer-tag-sys]
path = "../gstreamer-tag-sys"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@@ -16,6 +16,9 @@ path = "../gstreamer-audio-sys"
[dependencies.gstreamer-video-sys]
path = "../gstreamer-video-sys"

[dependencies.gstreamer-tag-sys]
path = "../gstreamer-tag-sys"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@GuillaumeGomez
Copy link
Contributor Author

@sdroege: How come you see unused crates? I don't have any warnings or anything. :-/

@sdroege
Copy link
Owner

sdroege commented Dec 3, 2017

I don't know why there's no warning, but nothing of those crates is used anywhere :)

@GuillaumeGomez
Copy link
Contributor Author

That's so strange. (I updated btw.)

@sdroege sdroege merged commit bcc17ef into sdroege:master Dec 3, 2017
@GuillaumeGomez GuillaumeGomez deleted the regen branch December 3, 2017 19:05
@GuillaumeGomez
Copy link
Contributor Author

🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants