-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regen #7
Regen #7
Conversation
It's failing because the code got some new "extern crate" but the Cargo.toml was not updated. However those crates are actually not used, so shouldn't be there to begin with. Also this update is "breaking" the versions in build.rs and Cargo.toml. It is removing some version features, which are there for consistency (everything has features for the major versions, 1.0, 1.2, 1.4, etc, independent of whether API was added or not... to make it simpler for users to select their required version without having to think/check). |
I'll clean this PR this evening then. :) |
52e8ebd
to
e7dcf22
Compare
Updated, sorry for the delay. There is still an issue remaining for the debug generation in gir (for cases like |
This issue should be fixed by rust-lang/rust#46445. |
gstreamer-app-sys/src/lib.rs
Outdated
extern crate glib_sys as glib; | ||
extern crate gobject_sys as gobject; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause warnings about unused crates
gstreamer-app-sys/Cargo.toml
Outdated
libc = "0.2" | ||
glib-sys = { git = "https://github.com/gtk-rs/sys" } | ||
gobject-sys = { git = "https://github.com/gtk-rs/sys" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused crates
@sdroege: Fixed and updated. |
See the warnings in the travis build. The ones I listed were only some of the many :) |
gstreamer-audio-sys/Cargo.toml
Outdated
@@ -13,6 +13,9 @@ path = "../gstreamer-sys" | |||
[dependencies.gstreamer-base-sys] | |||
path = "../gstreamer-base-sys" | |||
|
|||
[dependencies.gstreamer-tag-sys] | |||
path = "../gstreamer-tag-sys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
gstreamer-pbutils-sys/Cargo.toml
Outdated
@@ -16,6 +16,9 @@ path = "../gstreamer-audio-sys" | |||
[dependencies.gstreamer-video-sys] | |||
path = "../gstreamer-video-sys" | |||
|
|||
[dependencies.gstreamer-tag-sys] | |||
path = "../gstreamer-tag-sys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
@sdroege: How come you see unused crates? I don't have any warnings or anything. :-/ |
I don't know why there's no warning, but nothing of those crates is used anywhere :) |
That's so strange. (I updated btw.) |
🎊 |
Very sorry but I can't build it on my linux because my packages are too old. I can check it this evening though.