-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LMPOP #311
Add LMPOP #311
Conversation
If you are interested in carrying this further, I would welcome an upgrade of redis-rb to v5. In any case, really appreciate you putting up a draft PR. |
I'll wait a week or two to see if #293 progresses, if not I'll take a stab at updating to v5 from scratch myself |
A bunch of tests fail on my local environment, and also a bunch of CI checks fail too. They all seem unrelated to the LMPOP changes, so I'm not sure what's up. Do you have any ideas? |
@Palladinium the tests I see failing are all on Redis 6.2 and mention Lastly, the Overcommit failure seems like it would be solved by adding |
Ah of course, LMPOP was only introduced in Redis v7, so those failures make sense |
Sorry, I forgot |
Thank you for the quick turnaround! Released in 0.48.0 |
Currently failing due to needing redis-rb v5 (see also #281 and #293)