Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HC-393: add target tracking metric for autoscaling that allows for 1:1 scaling of jobs to workers #86

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

pymonger
Copy link
Contributor

Details of this PR is shared with hysds/hysds#128.

Specific to this repository, this PR:

  • add support to the sds CLI to allow end user to specify target tracking metric to use during sds cloud asg create
  • detects target tracking metric per queue in .sds/config and specifies the corresponding CloudWatch metric name
  • addresses an issue when running sds update mozart where the following error is encountered:
[100.104.10.132] out: ERROR: Exception:
[100.104.10.132] out: Traceback (most recent call last):
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 164, in exc_logging_wrapper
[100.104.10.132] out:     status = run_func(*args)
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper
[100.104.10.132] out:     return func(self, options, args)
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 404, in run
[100.104.10.132] out:     installed = install_given_reqs(
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/req/__init__.py", line 68, in install_given_reqs
[100.104.10.132] out:     uninstalled_pathset = requirement.uninstall(auto_confirm=True)
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/req/req_install.py", line 670, in uninstall
[100.104.10.132] out:     uninstalled_pathset = UninstallPathSet.from_dist(dist)
[100.104.10.132] out:   File "/export/home/hysdsops/verdi/lib/python3.9/site-packages/pip/_internal/req/req_uninstall.py", line 533, in from_dist
[100.104.10.132] out:     assert (
[100.104.10.132] out: AssertionError: Egg-link /export/home/hysdsops/verdi/ops/osaka-1.0.6 does not match installed location of osaka (at /export/home/hysdsops/verdi/ops/osaka)
[100.104.10.132] out:
Fatal error: run() received nonzero return code 2 while executing!
  • mitigates outstanding CVE's

Copy link
Contributor

@mcayanan mcayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pymonger pymonger merged commit 322dfc5 into develop Nov 30, 2021
@pymonger pymonger deleted the HC-393 branch November 30, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants