Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to fab-classic as it has active support and development #96

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

DustinKLo
Copy link
Contributor

fabric3 errors out running with this error when using python3.10:

from collections import Mapping

it should not be:

from collections.abc import Mapping

fab-classic made a fix to that and also wrapped the fix in a try/except block for backwards compatibility: their python 3.10 PR

fabric/main.py

import inspect
from optparse import OptionParser
from importlib import import_module
try:
    from collections.abc import Mapping
except ImportError:
    from collections import Mapping

import six

@pymonger was able to test this out and confirmed that sdscli is working as normal after we used this fabric fork instead
@mcayanan will also merge this into develop-v5 afterwards

@DustinKLo DustinKLo requested review from pymonger and mcayanan March 1, 2023 19:08
Copy link
Contributor

@mcayanan mcayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DustinKLo DustinKLo merged commit 2135270 into develop Mar 1, 2023
@DustinKLo DustinKLo deleted the hotfix-python3.10 branch March 1, 2023 19:12
DustinKLo added a commit that referenced this pull request Mar 1, 2023
Co-authored-by: Gerald Manipon <pymonger@gmail.com>
DustinKLo added a commit that referenced this pull request Mar 20, 2023
…s on Mozart ES (#100)

* HC-447: Added capability to rollover old job_status indices in Mozart ES (#94)

* HC-447: Add mechansim to roll of ES indices on Mozart

* install templates and bootstrap

* add new files

* cannot resolve role

* fix base path

* update

* modify to modern template payload

* update

* add comma

* dump json

* fix typo

* updates

* typo

* update

* make index pattern more specific

* remove alias

* update

* revert

* update

* update

* use the phases properly

* updated

* update

* update

* update

* add actions

* update

* update

* update policy

* update names to be consistent throughout

* revert

* revert back aliases

* update

* typo

* remove ILM from event, task, and worker templates

* remove alias

* revert back to default 8 shards

* No need to push index templates out as they are initialized elsewhere

* add aliases

* update

* update description

* bump version

* make a minor update

---------

Co-authored-by: Mike Cayanan <michael.d.cayanan@jpl.nasa.gov>

* move to fab-classic as it has active support and development (#96) (#98)

Co-authored-by: Gerald Manipon <pymonger@gmail.com>

* NSDS-2584 - Implement rollover of old task, worker, event ES docs on Mozart ES (#99)

* added lifecycle and aliases to templates

* using clean_indices_from_alias.py to remove mozart indices

* deleting templates is _index_template, not _template

* added note to location of template files

* commenting out this line b/c we shouldnt be deleting the templates

---------

Co-authored-by: dustinlo <dustin.k.lo@jpl.nasa.gov>

---------

Co-authored-by: Michael Cayanan <42812746+mcayanan@users.noreply.github.com>
Co-authored-by: Mike Cayanan <michael.d.cayanan@jpl.nasa.gov>
Co-authored-by: Gerald Manipon <pymonger@gmail.com>
Co-authored-by: dustinlo <dustin.k.lo@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants