-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newbranch #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point out the lines directly written by you
I have commented the html files which are in the pages folder as pls use "added" keyword to find the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go through the code and ensure proper indentation and line breaks. Remove unnecessary comments like I've pointed out. Good job!
<a href="4.html">4</a> | ||
</li> | ||
<li class="text-center relative"> | ||
<a href="6.html">5</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be 5.html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just vague data i have added the data in newbranch -3 pull req #4
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uniform indentation improves code readability.Try to have uniform indentation. Remove all unnecessary line breaks.
</div> | ||
<!-- /.col-lg-4 --> | ||
</div> | ||
<div class="col-lg-12"> <!--Added several changes in the discussion box--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment and other such unnecessary ones. Though commenting is a good practice :)
</div> | ||
</div> | ||
</li> | ||
<li><div class="extraspace"></div></li> <!--extra space added--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment
Created five pages using the bootstrap theme SB ADMIN-2