Make fontpreview more portable & fix some bugs #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PREFIX is a much more standard variable than DEST. - Add BINDIR to actually let people choose where to install fontpreview precisely if they need. - Support DESTDIR, which is useful for staged package building. While here, use tabs to indent values of variables. Spaces are sometimes significant in makefiles (they are parts of the values), which might lead to confusing bugs.
Also: - Do not put random strings into files inside the fontpreview directory. They are already unique there. - Exit with an error code if the program fails to create the temporary files.
The file name has to be the last argument. It was causing the following
errors:
sxiv: -N: No such file or directory
sxiv: fontpreview: No such file or directory
sxiv: -b: No such file or directory
As fontpreview is now using Bash instead of POSIX sh(1), there is no need to use single square brackets.
Procfs might not available on every platform. pgrep is much more portable.
|
I will take a look at this after #13 has been completed |
|
@sdushantha Cool, thanks! |
sdushantha
reviewed
Mar 4, 2020
|
Okay, everything looks good now and is ready to be merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am porting fontpreview to FreeBSD now and I've stumbled upon some issues (bugs & compatilibity issues).
Cheers! After those patches fontpreview is running very nicely on FreeBSD (the only drawback is that getopt is using some not so portable options so I have to patch fontpreview to use a non-FreeBSD getopt instead. I think that unless you want to change the way the command-line arguments are parsed, I am going to patch the fontpreview port on FreeBSD to use a different getopt (one coming from packages and not the one from the base system).