Resolve locales warning for providers that end with the locale name #702
Conversation
pvk-developer
requested review from
frances-h
and removed request for
a team
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1799 1802 +3
=========================================
+ Hits 1799 1802 +3
☔ View full report in Codecov by Sentry. |
rdt/transformers/pii/anonymizer.py
Outdated
| @@ -81,7 +81,7 @@ def _check_locales(self): | |||
| missed_locales = [] | |||
| for locale in locales: | |||
| spec = importlib.util.find_spec(f'faker.providers.{self.provider_name}.{locale}') | |||
| if spec is None: | |||
| if spec is None and not self.provider_name.endswith(locale): | |||
There was a problem hiding this comment.
Is it safe to assume that if the provider name ends with the locale, then it exists? Is it possible it's just a bad provider name that ends with a locale
There was a problem hiding this comment.
I think that you are right, we can improve this by adding .. to the locale when looking for.
There was a problem hiding this comment.
I meant more that I think we should make sure the provider exists still. Like if the locale is already present, extract it and runs it through importlib.util.find_spec(f'faker.providers....
pvk-developer
force-pushed
the
issue-701-resolve-locales-warning-for-specific-locale
branch
from
1630a12
to
b09f5a9
Compare
pvk-developer
deleted the
issue-701-resolve-locales-warning-for-specific-locale
branch
Resolves #701
Resolves sdv-dev/SDV#1480