ClusterBasedNormalizer code cleanup
#704
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1799 1800 +1
=========================================
+ Hits 1799 1800 +1
☔ View full report in Codecov by Sentry. |
|
Note: the lines |
fealho
requested review from
amontanez24,
pvk-developer and
a team
and removed request for
a team
| data = np.stack([recovered_data, data[:, -1]], axis=1) # noqa: PD013 | ||
| else: | ||
| data = recovered_data | ||
| recovered_data = np.stack([recovered_data, data[:, -1]], axis=1) # noqa: PD013 |
There was a problem hiding this comment.
Can we get rid of this noqa?
There was a problem hiding this comment.
Nope. It thinks that is pandas stack and tells you to use melt, which is a method numpy doesn't have.
There was a problem hiding this comment.
Is np.concatenate the same ?
There was a problem hiding this comment.
stack concatenates them along a different axis. It's also supposed to be faster. I think we could change it to np.concatenate([[array1], [array2]], axis=1), or something like that, but that just seemed more confusing than the noqa.
| data = np.stack([recovered_data, data[:, -1]], axis=1) # noqa: PD013 | ||
| else: | ||
| data = recovered_data | ||
| recovered_data = np.stack([recovered_data, data[:, -1]], axis=1) # noqa: PD013 |
There was a problem hiding this comment.
Is np.concatenate the same ?
Resolve #696.