Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store SDGym results into an S3 bucket #80

Closed
csala opened this issue May 17, 2021 · 1 comment · Fixed by #83
Closed

Store SDGym results into an S3 bucket #80

csala opened this issue May 17, 2021 · 1 comment · Fixed by #83
Assignees
@katxiao
Labels
internal The issue doesn't change the API or functionality
Milestone
0.3.1

Comments

@csala
Copy link
Contributor

csala commented May 17, 2021

  • SDGym version: 0.3.0

Description

Current SDGym implementation allows to produce a results table as either a DataFrame (when run from python) or as a CSV file stored in the local HDD.

It should also be possible to store the results in an S3 bucket, which would be triggered by passing an output_path that contains the S3 prefix:

Python:

sdgym.run(..., output_path='s3://my-bucket/path/to/my/results.csv')

CLI

sdgym run ... -o s3://my-bucket/path/to/my/results.csv

If the bucket is private, the AWS key and secret introduce in PR #74 should be used.
@csala csala mentioned this issue May 17, 2021
Closed
@csala csala added the internal The issue doesn't change the API or functionality label May 17, 2021
@csala csala added this to the 0.3.1 milestone May 17, 2021
@katxiao katxiao mentioned this issue May 17, 2021
Merged
@katxiao katxiao linked a pull request May 18, 2021 that will close this issue
Allow output_path to be a s3 path #83
Merged
@csala
Copy link
Contributor Author

csala commented May 20, 2021

Closed via #83

@csala csala closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katxiao katxiao

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Allow output_path to be a s3 path sdv-dev/SDGym
2 participants
@katxiao @csala